Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetLogFilenameExtension extension as a suffix to log file name #197

Closed
wants to merge 1 commit into from

Conversation

gangadharmgithub
Copy link

Fix for #124.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@gangadharmgithub
Copy link
Author

I have signed the CLA

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@sammcj
Copy link

sammcj commented Feb 15, 2018

Can this please be merged if possible?

@YorkTsai2012
Copy link

@googlebot Why this PR is still not merged into master branch?

@sergiud
Copy link
Collaborator

sergiud commented Mar 2, 2018

googlebot does not merge anything. The PR has not been merged yet because no one reviewed the PR.

@dkteo
Copy link

dkteo commented Jun 12, 2019

@shinh PTAL

@sergiud
Copy link
Collaborator

sergiud commented Sep 29, 2020

Please resolve the conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants