Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build with Bazel. #232

Merged
merged 5 commits into from
Dec 18, 2017
Merged

Build with Bazel. #232

merged 5 commits into from
Dec 18, 2017

Commits on Dec 14, 2017

  1. Build with Bazel.

    @qzmfranklin
    qzmfranklin committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    921651e View commit details
    Browse the repository at this point in the history

  2. Can build with Bazel now

    @qzmfranklin
    qzmfranklin committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    004fc8c View commit details
    Browse the repository at this point in the history

  3. Hide certain header files from the cc_library(). 

    This commit addresses a few issues:

    1.  No longer leak config.h in a way similar to
            gflags/gflags#233
        The solution of prefixing the path by 'glog_internal' is modified from
            gflags/gflags#234

    2.  No longer expose internal headers.

    3.  Replace PACKAGE_NAME with native.package_name()

    4.  Uers can choose namespaces via the newly added 'namespace' keyword.

    5.  Replace glob with explicitly listing of files.

    6.  Make the genrules more compact using pythonic list construction.
    @qzmfranklin
    qzmfranklin committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    e6e2e13 View commit details
    Browse the repository at this point in the history

  4. Remove an empty textual_hdrs field.

    @qzmfranklin
    qzmfranklin committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    ea458f6 View commit details
    Browse the repository at this point in the history

  5. Remove the use of bind() from WORKSPACE.

    @qzmfranklin
    qzmfranklin committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    389a778 View commit details
    Browse the repository at this point in the history