Fix username lookup in case of missing USER environment variable #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trixi1977
approved these changes
Sep 24, 2017
|
Ping? |
shinh
approved these changes
Oct 20, 2017
| #if defined(HAVE_PWD_H) && defined(HAVE_UNISTD_H) | ||
| uid_t uid; | ||
| struct passwd pwd; | ||
| struct passwd*result = NULL; |
There was a problem hiding this comment.
Could you add a whitespace right before "result"?
struct passwd* result = NULL
| struct passwd*result = NULL; | ||
| char buffer[1024] = {'\0'}; | ||
| uid = geteuid(); | ||
| int pwuid_res = getpwuid_r(uid, &pwd, buffer, sizeof (buffer), &result); |
There was a problem hiding this comment.
Could you remove the whitespace between sizeof and buffer?
| int pwuid_res = getpwuid_r(uid, &pwd, buffer, sizeof (buffer), &result); | ||
| if(pwuid_res == 0) { | ||
| g_my_user_name = pwd.pw_name; | ||
| } |
There was a problem hiding this comment.
Please concatenate with the next line
| char buffer[1024] = {'\0'}; | ||
| uid = geteuid(); | ||
| int pwuid_res = getpwuid_r(uid, &pwd, buffer, sizeof (buffer), &result); | ||
| if(pwuid_res == 0) { |
|
Sorry for the latency.. |
|
Thanks |
durswd
pushed a commit
to durswd/glog
that referenced
this pull request
Sep 2, 2019
Fix username lookup in case of missing USER environment variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue with invalid-user in file prefix when USER environment variable is not defined.