Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example using glog from Bazel #276

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Conversation

drigz
Copy link
Member

@drigz drigz commented Dec 19, 2017

Combined with the coming job on ci.bazel.io, this should help keep the build working.

@iirina For the Bazel build.
@shinh For the example.

size = "small",
srcs = ["main.cc"],
deps = [
"@com_google_glog//:glog",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to reference the workspace name here since you are in the same workspace

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. This was left over from my first attempt to have the example use com_google_glog as an external repo.

Thanks for the review!

WORKSPACE Outdated
@@ -1,5 +1,7 @@
workspace(name = "com_google_glog")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also unnecessary because you don't have multiple workspaces

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@drigz drigz merged commit 5b1aa94 into google:master Jan 4, 2018
durswd pushed a commit to durswd/glog that referenced this pull request Sep 2, 2019
Add an example using glog from Bazel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants