Fix stacktrace on Bazel build. #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be super cool. |
|
sorry for late. seems PR is too old for buildkite verification. |
We need at least following defs to be set to print stacktrace in failure signal handler. - HAVE_UNWIND_H: on Linux and macOS. unwind.h is usually present by default on those OSes. - HAVE_DLADDR: on macOS. Windows is not cared because glog can not be built with bazel on Windows today.
|
Sure, rebased. |
durswd
pushed a commit
to durswd/glog
that referenced
this pull request
Sep 2, 2019
We need at least following defs to be set to print stacktrace in failure signal handler. - HAVE_UNWIND_H: on Linux and macOS. unwind.h is usually present by default on those OSes. - HAVE_DLADDR: on macOS. Windows is not cared because glog can not be built with bazel on Windows today.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need at least following defs to be set to print stacktrace in
failure signal handler.
by default on those systems.
Note that today glog does not build with Bazel on Windows.
Resolves #346.