Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/utilities: fix build without pthread #477

Merged
merged 1 commit into from
Nov 2, 2019
Merged

src/utilities: fix build without pthread #477

merged 1 commit into from
Nov 2, 2019

Conversation

ffontaine
Copy link
Contributor

  • Remove is_default_thread function which is an internal and not used
    function
  • Remove g_main_thread_id as it was used only by is_default_thread

Fixes:

Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com

@sergiud
Copy link
Collaborator

sergiud commented Oct 31, 2019

Your PR fails to build.

@ffontaine
Copy link
Contributor Author

PR is now ok on Travis. Remaining errors are not related with this PR:

/usr/src/app/src/logging_unittest.cc:43:10: fatal error: sys/wait.h: No such file or directory
 #include <sys/wait.h>

@sergiud
Copy link
Collaborator

sergiud commented Nov 1, 2019

Please rebase and let the CI run again.

@googlebot
Copy link
Collaborator

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Nov 1, 2019
@ffontaine
Copy link
Contributor Author

I'm not sufficiently familiar with rebasing :-/ I think I screw it :-/ I can always create a brand new PR if needed.

- Remove is_default_thread function which is an internal and not used
  function
- Remove g_main_thread_id as it was used only by is_default_thread

Fixes:
 - http://autobuild.buildroot.net/results/5320bbe1205e782e3516d9bead8d1ed825bcbaad

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Nov 2, 2019
@sergiud sergiud added the LGTM label Nov 2, 2019
@sergiud sergiud merged commit 4d6aff4 into google:master Nov 2, 2019
@sergiud sergiud added this to the 0.5 milestone Mar 30, 2021
@sergiud sergiud mentioned this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants