Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address review comments for Bazel/Win32 build #499

Merged
merged 3 commits into from
Nov 27, 2019
Merged

Address review comments for Bazel/Win32 build #499

merged 3 commits into from
Nov 27, 2019

Commits on Nov 20, 2019

  1. Avoid leaking config.h 

    This uses strip_include_prefix to avoid leaking private headers
(config.h, port.h). This needs a workaround to prevent a "missing
dependency declarations" error.
    @drigz
    drigz committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    1bb0133 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary defines 

    The only macro referenced by the public headers is GOOGLE_GLOG_DLL_DECL.
This means fewer defines are propagated to rules that depend on glog.
    @drigz
    drigz committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    23c7054 View commit details
    Browse the repository at this point in the history

  3. Add note about namespace on Win32.

    @drigz
    drigz committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    9b75699 View commit details
    Browse the repository at this point in the history