Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: export symbols selectively #619

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Mar 30, 2021

Unless a symbol is explicitly exported, the CMake build now hides all remaining declarations. This change particularly reduces the size of the generated .so.

Closes #469, closes #575

@google-cla google-cla bot added the cla: yes label Mar 30, 2021
@sergiud sergiud linked an issue Mar 30, 2021 that may be closed by this pull request
@sergiud sergiud self-assigned this Mar 30, 2021
@sergiud sergiud added this to the 0.5 milestone Mar 30, 2021
@sergiud sergiud merged commit 45fdc92 into google:master Mar 30, 2021
@sergiud sergiud mentioned this pull request May 6, 2021
@sergiud sergiud deleted the cmake-proper-symbol-export branch February 12, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails with clang-cl due to undefined symbols GOOGLE_GLOG_DLL_DECL needs to be put into header file
1 participant