Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use generated config.h for Windows. #635

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Use generated config.h for Windows. #635

merged 1 commit into from
Apr 6, 2021

Conversation

drigz
Copy link
Member

@drigz drigz commented Apr 6, 2021

This unblocks a simplification of the Windows CMake build.

@drigz
Use generated config.h for Windows.
1041a22 
This unblocks a simplification of the Windows CMake build.
@drigz drigz requested a review from sergiud April 6, 2021 12:03
@google-cla google-cla bot added the cla: yes label Apr 6, 2021
sergiud
sergiud approved these changes Apr 6, 2021
View reviewed changes
Copy link
Collaborator

@sergiud sergiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks!

@sergiud sergiud added this to the 0.5 milestone Apr 6, 2021
@sergiud sergiud merged commit 36e6ed9 into master Apr 6, 2021
@sergiud sergiud deleted the win-headers branch April 6, 2021 20:50
@sergiud sergiud mentioned this pull request May 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiud sergiud sergiud approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@drigz @sergiud