Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export OS_* defines (fixes #715) #716

Merged
merged 1 commit into from
Oct 1, 2021
Merged

export OS_* defines (fixes #715) #716

merged 1 commit into from
Oct 1, 2021

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Oct 1, 2021

Moved OS_* defines to a separate public header and added a GLOG_ prefix.

@sergiud sergiud added the bug label Oct 1, 2021
@sergiud sergiud added this to the 0.6 milestone Oct 1, 2021
@sergiud sergiud requested a review from drigz October 1, 2021 09:32
@google-cla google-cla bot added the cla: yes label Oct 1, 2021
@sergiud sergiud linked an issue Oct 1, 2021 that may be closed by this pull request
Copy link
Member

@drigz drigz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sergiud sergiud merged commit 5652319 into master Oct 1, 2021
@sergiud sergiud deleted the export-os-defines branch October 1, 2021 10:50
@draveness
Copy link

@sergiud can we release a new version to fix this?

@sergiud
Copy link
Collaborator Author

sergiud commented Nov 17, 2021

Please see the corresponding milestone. The date can change though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OS_* defines not always set correctly
3 participants