Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use uint32 for --max-log-size #773

Merged
merged 1 commit into from
Dec 29, 2021
Merged

use uint32 for --max-log-size #773

merged 1 commit into from
Dec 29, 2021

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Dec 23, 2021

Related to #497

@sergiud sergiud added this to the 0.6 milestone Dec 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2021

Codecov Report

Merging #773 (588d298) into master (42d509b) will increase coverage by 1.97%.
The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #773      +/-   ##
==========================================
+ Coverage   72.62%   74.59%   +1.97%     
==========================================
  Files          17       17              
  Lines        3240     3791     +551     
==========================================
+ Hits         2353     2828     +475     
- Misses        887      963      +76     
Impacted Files Coverage Δ
src/glog/logging.h.in 78.07% <ø> (-1.93%) ⬇️
src/logging.cc 77.15% <78.94%> (+3.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42d509b...588d298. Read the comment docs.

@sergiud sergiud merged commit b3abfaa into master Dec 29, 2021
@sergiud sergiud deleted the max-log-size-uint32 branch December 29, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants