Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Respect TEST_TMPDIR, TMPDIR, TMP environmental variables #794

Merged
merged 2 commits into from
Feb 20, 2022
Merged

Tests: Respect TEST_TMPDIR, TMPDIR, TMP environmental variables #794

merged 2 commits into from
Feb 20, 2022

Conversation

Arfrever
Copy link

Use GetExistingTempDirectories() (which uses GetTempDirectories() which respects
TEST_TMPDIR, TMPDIR, TMP environmental variables) for FLAGS_test_tmpdir variable
used in some tests.

Fixes: #793

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2022

Codecov Report

Merging #794 (6d3f70a) into master (b38ed9d) will increase coverage by 0.24%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #794      +/-   ##
==========================================
+ Coverage   72.78%   73.02%   +0.24%     
==========================================
  Files          17       17              
  Lines        3259     3259              
==========================================
+ Hits         2372     2380       +8     
+ Misses        887      879       -8     
Impacted Files Coverage Δ
src/glog/logging.h.in 80.00% <0.00%> (ø)
src/logging.cc 74.29% <0.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b38ed9d...6d3f70a. Read the comment docs.

Copy link
Collaborator

@sergiud sergiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Only couple of suggestions.

src/googletest.h Outdated Show resolved Hide resolved
src/googletest.h Outdated Show resolved Hide resolved
@sergiud sergiud added the bug label Feb 19, 2022
@sergiud sergiud added this to the 0.6 milestone Feb 19, 2022
Arfrever Frehtes Taifersar Arahesis added 2 commits February 19, 2022 20:07
Use GetExistingTempDirectories() (which uses GetTempDirectories() which respects
TEST_TMPDIR, TMPDIR, TMP environmental variables) for FLAGS_test_tmpdir variable
used in some tests.

Fixes: #793
@sergiud
Copy link
Collaborator

sergiud commented Feb 20, 2022

Thank you!

@sergiud sergiud merged commit 553ddae into google:master Feb 20, 2022
@Arfrever Arfrever deleted the tests-TMPDIR branch February 20, 2022 21:35
@Izzy1405 Izzy1405 mentioned this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test suite does not fully respect ${TMPDIR}
3 participants