Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetLogger should delete previously set custom logger. #853

Merged
merged 2 commits into from
Aug 13, 2022
Merged

SetLogger should delete previously set custom logger. #853

merged 2 commits into from
Aug 13, 2022

Commits on Aug 13, 2022

  1. SetLogger should delete previously set custom logger. 

    As specified in the doc comment for SetLogger, "the logger becomes the
property of the logging module and should not be deleted by the caller".

Not only should the LogDestination delete a custom logger in its
destructor, but it should also delete a previous logger when another
logger is passed to SetLogger().
    @anpol
    anpol committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    85f3621 View commit details
    Browse the repository at this point in the history

  2. Update src/logging.cc 

    Co-authored-by: Sergiu Deitsch <sergiud@users.noreply.github.com>
    @anpol @sergiud
    anpol and sergiud committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    c0fc870 View commit details
    Browse the repository at this point in the history