Implement GLOME login INI config parsing in Go. #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkern
requested changes
Aug 23, 2023
|
LGTM, but can we please keep track of the problems with our config format that prevent us from using an ini parser dependency? Next time we touch the config format, we could aim to fix those. |
pkern
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
From my side this LGTM now. I'm with Markus that we shoud document somewhere (maybe in the commit description? or in a source comment...) why we chose this route. If it's just about the value parsing, we should've been able to do that also with another implementation. That said, Parse() is actually very small and the remainder is spent on putting the values into the right places, so this is fine with me for now.
This implements INI parsing internally, rather than pulling in a library because we want to exactly match the behaviour of the C library, and our INI-parsing has a few quirks (as do all INI parsers...) - for instance, we only support comments if they're on their own line. Additionally, the code that does the INI parsing is relatively small; the bulk of the code is actually parsing things into application specific structs, which we would need to do anyway. Possibly this is ripe for switching to TOML, but we'd still have to e.g. parse string encoded keys to binary/validate that the options set are compatible with each other. Fixes google#168.
burgerdev
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements INI parsing internally, rather than pulling in a library because
we want to exactly match the behaviour of the C library, and our INI-parsing has
a few quirks (as do all INI parsers...) - for instance, we only support comments
if they're on their own line.
Additionally, the code that does the INI parsing is relatively small; the bulk of
the code is actually parsing things into application specific structs, which we
would need to do anyway. Possibly this is ripe for switching to TOML, but we'd still
have to e.g. parse string encoded keys to binary/validate that the options set
are compatible with each other.
Fixes #168.