Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RFD001 in C #170

Merged
merged 6 commits into from
Oct 2, 2023
Merged

Implement RFD001 in C #170

merged 6 commits into from
Oct 2, 2023

Conversation

burgerdev
Copy link
Collaborator

No description provided.

@burgerdev burgerdev requested a review from vvidic September 15, 2023 17:26
Copy link
Collaborator

@vvidic vvidic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine by me, just update the TODO comments.

login/crypto.c Outdated Show resolved Hide resolved
login/login.c Outdated Show resolved Hide resolved
@burgerdev burgerdev marked this pull request as ready for review September 25, 2023 14:13
@burgerdev burgerdev requested a review from vvidic September 25, 2023 14:14
@burgerdev
Copy link
Collaborator Author

I worked on the TODOs, but that resulted in quite some more changes to API etc. Might make sense to take another pass here. Otherwise, I'll merge this next week.

login/login.c Outdated Show resolved Hide resolved
@burgerdev burgerdev merged commit 6202d0a into google:master Oct 2, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants