Avoid calling openlog when using GLOME as a library #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkern
reviewed
Jan 25, 2024
This causes log lines to always use `glome-login` as the ident, which isn't necessarily desirable. We can just not call openlog: if we don't call it, syslog will initialise with some default values (i.e. not including the PID). To avoid this then logging to the wrong facility we update our own calls to syslog to explicitly set the facility. PAM doesn't need a facility; it appears to just use LOG_AUTHPRIV internally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes log lines to always use
glome-loginas the ident, which isn't necessarily desirable.We can just not call openlog: if we don't call it, syslog will initialise with some default values (i.e. not including the PID), so this won't break any users of GLOME-as-a-library who don't update to call
openlog. To avoid this then logging to the wrong facility we update our own calls to syslog to explicitly set the facility.PAM doesn't need a facility; it appears to just use LOG_AUTHPRIV internally.