Disable bracketed paste #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some settings we seem to end up with users' terminals being confused and willing to send bracketed paste escape codes, which then cause authentication to fail. Even worse it looks like the special characters are not displayed in some shells, thus confusing users as to what just happened. Although to be honest: I have not found the specific environment where this breaks in a reproducible fashion and this is effectively defence in depth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some settings we seem to end up with users' terminals being confused and willing to send bracketed paste escape codes, which then cause authentication to fail. Even worse it looks like the special characters are not displayed in some shells, thus confusing users as to what just happened.
Although to be honest: I have not found the specific environment where this breaks in a reproducible fashion and this is effectively defence in depth.