Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x509ext: initial version of package #279

Merged
merged 1 commit into from
Jun 2, 2022
Merged

x509ext: initial version of package #279

merged 1 commit into from
Jun 2, 2022

Conversation

brandonweeks
Copy link
Member

Future PRs will:

  • Add roundtrip tests.
  • Replace usage of encoding/asn1 with golang.org/x/crypto.
  • Add packages for parsing attestation key and endorsement key certificates.

This PR is just intended to harmonize google3 and brandonweeks/acme-device-attest-demo.

ericchiang
ericchiang approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@ericchiang ericchiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests? :P

@brandonweeks brandonweeks merged commit cb97608 into google:master Jun 2, 2022
@brandonweeks brandonweeks deleted the x509ext branch November 30, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericchiang ericchiang ericchiang approved these changes

@twitchyliquid64 twitchyliquid64 Awaiting requested review from twitchyliquid64

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandonweeks @ericchiang