Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golangci-lint workflow #336

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Fix golangci-lint workflow #336

merged 1 commit into from
Jun 20, 2023

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Jun 20, 2023 •
edited
Loading

  • use go1.20 to follow the go.mod and the other workflow.
  • use golangci-lint v1.53.3 to have the support of go1.20

Those elements were missing inside #331: the PR was merged despite the failure of CI and as the
golangci-lint workflow is only called for PRs the failure doesn't appear on the branch master.

@ldez ldez mentioned this pull request Jun 20, 2023
Closed
4 tasks
@brandonweeks brandonweeks merged commit 2788b54 into google:master Jun 20, 2023
@brandonweeks
Copy link
Member

Thank you!

@ldez ldez deleted the fix/ci-lint branch June 20, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonweeks brandonweeks brandonweeks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ldez @brandonweeks