all: update to go version 1.23 (#3467)

google · Aug 13, 2024 · 3d1f45c · 3d1f45c
1 parent 56e722d
commit 3d1f45c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -24,13 +24,10 @@ jobs:
         os: [ubuntu-latest, macos-latest]
         # When updating this, make sure to also update the
         # latest_go_version variable in internal/testing/runchecks.sh.
-        # Restore previous version when go 1.23 is out; go 1.22
-        # purposefully broke some backwards compatibility that breaks
-        # the golden tests, so I've disabled them for now.
-        go-version: [1.22.x]
-          #include:
-          #- go-version: 1.21.x
-          #os: ubuntu-latest
+        go-version: [1.23.x]
+        include:
+          - go-version: 1.22.x
+            os: ubuntu-latest
 
     runs-on: ${{ matrix.os }}
     steps:

diff --git a/internal/testing/runchecks.sh b/internal/testing/runchecks.sh
@@ -44,7 +44,7 @@ rootdir="$(pwd)"
 # new Go version. Some checks below we only run
 # for the latest Go version.
 latest_go_version=0
-if [[ $(go version) == *go1\.22* ]]; then
+if [[ $(go version) == *go1\.23* ]]; then
   latest_go_version=1
 fi