fix(docstore/awsdynamodb): ensure Next returns EOF when no more items #3406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3406 +/- ##
==========================================
- Coverage 73.13% 73.12% -0.01%
==========================================
Files 113 113
Lines 14862 14864 +2
==========================================
Hits 10870 10870
- Misses 3218 3219 +1
- Partials 774 775 +1 ☔ View full report in Codecov by Sentry. |
vangent
approved these changes
Mar 21, 2024
renovate bot
added a commit
to open-feature/flagd
that referenced
this pull request
Sep 11, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [gocloud.dev](https://redirect.github.com/google/go-cloud) | `v0.37.0` -> `v0.39.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>google/go-cloud (gocloud.dev)</summary> ### [`v0.39.0`](https://redirect.github.com/google/go-cloud/releases/tag/v0.39.0) [Compare Source](https://redirect.github.com/google/go-cloud/compare/v0.38.0...v0.39.0) #### BREAKING CHANGE (AWS only, V1 vs V2 SDK) Context: AWS has [announced maintenance mode](https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/) for the Go V1 SDK. Go CDK has changed the default SDK for URLs across all modules except `docstore/awsdynamodb` to be V2 (previously you needed to add `awssdk=v2` to the URL to get V2). Most URLs should continue to work, but in some cases you may need to add `awssdk=v1` to force V1 explicitly. Also, concrete type constructors (e.g., `OpenBucket`) for V1 (again, except `docstore/awsdynamodb`) have been marked deprecated; please migrate to using the V2 versions (e.g., `OpenBucketV2`). Our tentative plan is to remove support for V1 in early 2025; please [file a bug](https://redirect.github.com/google/go-cloud/issues/new/choose) if you have concerns about that. #### What's Changed - pubsub: Make batch request results independent by [@​mitsos1os](https://redirect.github.com/mitsos1os) in [google/go-cloud#3457 - docstore/all: Add support for boolean filter by [@​ybourgery](https://redirect.github.com/ybourgery) in [google/go-cloud#3464 - aws/all: Mark V1 constructors deprecated. by [@​vangent](https://redirect.github.com/vangent) in [google/go-cloud#3466 - aws/all: Change the default for AWS URLs from V1 to V2. by [@​vangent](https://redirect.github.com/vangent) in [google/go-cloud#3465 - all: update to go version 1.23 by [@​vangent](https://redirect.github.com/vangent) in [google/go-cloud#3467 #### New Contributors - [@​mitsos1os](https://redirect.github.com/mitsos1os) made their first contribution in [google/go-cloud#3457 - [@​dependabot](https://redirect.github.com/dependabot) made their first contribution in [google/go-cloud#3448 **Full Changelog**: google/go-cloud@v0.38.0...v0.39.0 ### [`v0.38.0`](https://redirect.github.com/google/go-cloud/releases/tag/v0.38.0) [Compare Source](https://redirect.github.com/google/go-cloud/compare/v0.37.0...v0.38.0) **blob** - **all**: Fix panics if reader recreation fails after Seek by [@​vangent](https://redirect.github.com/vangent) in [google/go-cloud#3425 - **all**: Convert errors in `Open()` into appropriate fs errors by [@​milescrabill](https://redirect.github.com/milescrabill) in [google/go-cloud#3443 - **s3blob**: Fix Copy to work with keys that need escaping by [@​vangent](https://redirect.github.com/vangent) in [google/go-cloud#3403 - **azureblob**: Do not panic if Content-Length and Content-Range are missing by [@​chancez](https://redirect.github.com/chancez) in [google/go-cloud#3445 - **fileblob**: Allow customization of the FileMode by [@​vangent](https://redirect.github.com/vangent) in [google/go-cloud#3426 **pubsub** - **awssnssqs**: Add support for setting FIFO message metadata by [@​bartventer](https://redirect.github.com/bartventer) in [google/go-cloud#3435 - **kafkapubsub**: Configuring key_name when OpenTopicURL by [@​ssetin](https://redirect.github.com/ssetin) in [google/go-cloud#3404 - **rabbitpubsub**: Add query string set the qos prefetch count by [@​peczenyj](https://redirect.github.com/peczenyj) in [google/go-cloud#3431 - **rabbitpubsub**: Add query string to set the routing key from metadata by [@​peczenyj](https://redirect.github.com/peczenyj) in [google/go-cloud#3433 - **rabbitpubsub**: Wrap pubsub rabbitmq errors by [@​peczenyj](https://redirect.github.com/peczenyj) in [google/go-cloud#3437 **docstore** - **all**: Fix offset handling and extend test coverage by [@​bartventer](https://redirect.github.com/bartventer) in [google/go-cloud#3409 - **awsdynamodb**: Ensure Next returns EOF when no more items by [@​bartventer](https://redirect.github.com/bartventer) in [google/go-cloud#3406 - **mongodocstore**: Update Mongo dialer when MONGO_SERVER_URL rotates by [@​concaf](https://redirect.github.com/concaf) in [google/go-cloud#3429 #### New Contributors - [@​ssetin](https://redirect.github.com/ssetin) made their first contribution in [google/go-cloud#3404 - [@​concaf](https://redirect.github.com/concaf) made their first contribution in [google/go-cloud#3429 - [@​peczenyj](https://redirect.github.com/peczenyj) made their first contribution in [google/go-cloud#3431 - [@​chancez](https://redirect.github.com/chancez) made their first contribution in [google/go-cloud#3445 - [@​milescrabill](https://redirect.github.com/milescrabill) made their first contribution in [google/go-cloud#3443 - [@​samlaf](https://redirect.github.com/samlaf) made their first contribution in [google/go-cloud#3450 **Full Changelog**: google/go-cloud@v0.37.0...v0.38.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-feature/flagd). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43NC4xIiwidXBkYXRlZEluVmVyIjoiMzguNzQuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3405
Although I was unable to reproduce the panic, I added a preventive check for
awsdynamodbhere. This check returnsio.EOFif there are no more items, which should prevent anindex out of rangepanic whenNextis called after it has already returnedEOFonce.I also added a test case to verify this behavior. The test repeatedly calls
Nextuntil it getsio.EOF, then callsNextagain to ensure it still returnsio.EOF.I also generated new replay files for
awsdynamodbandgcpfirestore.