Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump deps, fix issues #1317

Merged
merged 5 commits into from
May 10, 2022
Merged

Bump deps, fix issues #1317

merged 5 commits into from
May 10, 2022

Conversation

imjasonh
Copy link
Collaborator

@imjasonh imjasonh commented Mar 15, 2022 •
edited
Loading

Fixes #1361

@imjasonh imjasonh requested a review from mattmoor March 15, 2022 14:51
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022 •
edited
Loading

Codecov Report

Merging #1317 (033580d) into main (82405e5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1317   +/-   ##
=======================================
  Coverage   74.19%   74.19%           
=======================================
  Files         113      113           
  Lines        8436     8436           
=======================================
  Hits         6259     6259           
  Misses       1571     1571           
  Partials      606      606

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82405e5...033580d. Read the comment docs.

@imjasonh
Copy link
Collaborator Author

misspell doesn't ignore vendor/... 😒

@imjasonh
Copy link
Collaborator Author

Bump deps failed again for the same reason: https://github.com/google/go-containerregistry/actions/runs/2020584456

@imjasonh
Copy link
Collaborator Author

Updated this to use -compat=1.17 for all the modules.

@imjasonh imjasonh mentioned this pull request May 10, 2022
Closed
@imjasonh imjasonh merged commit 03eb0a0 into google:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonjohnsonjr jonjohnsonjr jonjohnsonjr approved these changes

@mattmoor mattmoor mattmoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ggcr: Docker version upgrade ?
4 participants
@imjasonh @codecov-commenter @mattmoor @jonjohnsonjr