add --blobs-to-disk to 'crane registry serve' #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Hall <jason@chainguard.dev>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| m.lock.Lock() | ||
| defer m.lock.Unlock() | ||
|
|
||
| fi, err := os.Stat(filepath.Join(m.dir, h.String())) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
| m.lock.Lock() | ||
| defer m.lock.Unlock() | ||
|
|
||
| return os.Open(filepath.Join(m.dir, h.String())) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
| m.lock.Lock() | ||
| defer m.lock.Unlock() | ||
|
|
||
| f, err := os.Create(filepath.Join(m.dir, h.String())) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
| m.lock.Lock() | ||
| defer m.lock.Unlock() | ||
|
|
||
| return os.Remove(filepath.Join(m.dir, h.String())) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
mattmoor
approved these changes
Jun 15, 2023
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
Codecov Report
@@ Coverage Diff @@
## main #1731 +/- ##
==========================================
- Coverage 72.02% 71.88% -0.14%
==========================================
Files 121 122 +1
Lines 9777 9818 +41
==========================================
+ Hits 7042 7058 +16
- Misses 2060 2080 +20
- Partials 675 680 +5
|
mattmoor
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only writes blobs to disk, and keeps manifests in memory. This is mostly a short-term bandaid to be able to store more/larger images while we work on a storage backend that writes to an OCI layout.
...do some pushes...