Referrer API must return correct Content-Type #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the spec, Content-Type header MUST be set to application/vnd.oci.image.index.v1+json This is important as GAR today (OCI 1.0) redirect "referrers" API call to the authentication page, and doing so the call return 200 OK + content-type: text/html.
imjasonh
approved these changes
Jul 2, 2024
jonjohnsonjr
approved these changes
Jul 2, 2024
renovate bot
referenced
this pull request
in validator-labs/validator-plugin-oci
Jul 9, 2024
…0.20.0 (#207) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/google/go-containerregistry](https://togithub.com/google/go-containerregistry) | `v0.19.2` -> `v0.20.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>google/go-containerregistry (github.com/google/go-containerregistry)</summary> ### [`v0.20.0`](https://togithub.com/google/go-containerregistry/releases/tag/v0.20.0) [Compare Source](https://togithub.com/google/go-containerregistry/compare/v0.19.2...v0.20.0) #### What's Changed - Referrer API must return correct Content-Type by [@​GregoireW](https://togithub.com/GregoireW) in [https://github.com/google/go-containerregistry/pull/1968](https://togithub.com/google/go-containerregistry/pull/1968) - 🚨 POTENTIALLY BREAKING: Restore blind-write to remote.Put by [@​jonjohnsonjr](https://togithub.com/jonjohnsonjr) in [https://github.com/google/go-containerregistry/pull/1970](https://togithub.com/google/go-containerregistry/pull/1970) #### New Contributors - [@​GregoireW](https://togithub.com/GregoireW) made their first contribution in [https://github.com/google/go-containerregistry/pull/1968](https://togithub.com/google/go-containerregistry/pull/1968) **Full Changelog**: google/go-containerregistry@v0.19.2...v0.20.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/validator-labs/validator-plugin-oci). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJnbyJdfQ==--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
andrewpollock
referenced
this pull request
in google/osv-scanner
Jul 23, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | Type | Update | |---|---|---|---|---|---|---|---| | [github.com/charmbracelet/lipgloss](https://togithub.com/charmbracelet/lipgloss) | `v0.11.0` -> `v0.12.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | [github.com/gkampitakis/go-snaps](https://togithub.com/gkampitakis/go-snaps) | `v0.5.4` -> `v0.5.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/google/go-containerregistry](https://togithub.com/google/go-containerregistry) | `v0.19.2` -> `v0.20.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | [github.com/owenrumney/go-sarif/v2](https://togithub.com/owenrumney/go-sarif) | `v2.3.2` -> `v2.3.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | golang.org/x/exp | `46b0784` -> `8a7402a` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | digest | --- ### Release Notes <details> <summary>charmbracelet/lipgloss (github.com/charmbracelet/lipgloss)</summary> ### [`v0.12.1`](https://togithub.com/charmbracelet/lipgloss/releases/tag/v0.12.1) [Compare Source](https://togithub.com/charmbracelet/lipgloss/compare/v0.12.0...v0.12.1) This release fixes a regression with regard to border calculations introduced in Lip Gloss v0.11.1. *** <a href="https://charm.sh/"><img alt="The Charm logo" src="https://stuff.charm.sh/charm-badge.jpg" width="400"></a> Thoughts? Questions? We love hearing from you. Feel free to reach out on [Twitter](https://twitter.com/charmcli), [The Fediverse](https://mastodon.technology/@​charm), or on [Discord](https://charm.sh/chat). ### [`v0.12.0`](https://togithub.com/charmbracelet/lipgloss/releases/tag/v0.12.0) [Compare Source](https://togithub.com/charmbracelet/lipgloss/compare/v0.11.1...v0.12.0) ### Lists, Check ✓ This release adds a new sub-package for rendering trees and lists. ```go import "github.com/charmbracelet/lipgloss/list" ``` Define a new list. ```go l := list.New("A", "B", "C") ``` Print the list. ```go fmt.Println(l) // • A // • B // • C ``` Lists have the ability to nest. ```go l := list.New( "A", list.New("Artichoke"), "B", list.New("Baking Flour", "Bananas", "Barley", "Bean Sprouts"), "C", list.New("Cashew Apple", "Cashews", "Coconut Milk", "Curry Paste", "Currywurst"), "D", list.New("Dill", "Dragonfruit", "Dried Shrimp"), "E", list.New("Eggs"), "F", list.New("Fish Cake", "Furikake"), "J", list.New("Jicama"), "K", list.New("Kohlrabi"), "L", list.New("Leeks", "Lentils", "Licorice Root"), ) ``` Print the list. ```go fmt.Println(l) ``` <p align="center"> <img width="600" alt="image" src="https://github.com/charmbracelet/lipgloss/assets/42545625/0dc9f440-0748-4151-a3b0-7dcf29dfcdb0"> </p> Lists can be customized via their enumeration function as well as using `lipgloss.Style`s. ```go enumeratorStyle := lipgloss.NewStyle().Foreground(lipgloss.Color("99")).MarginRight(1) itemStyle := lipgloss.NewStyle().Foreground(lipgloss.Color("212")).MarginRight(1) l := list.New( "Glossier", "Claire’s Boutique", "Nyx", "Mac", "Milk", ). Enumerator(list.Roman). EnumeratorStyle(enumeratorStyle). ItemStyle(itemStyle) ``` Print the list. <p align="center"> <img width="600" alt="List example" src="https://github.com/charmbracelet/lipgloss/assets/42545625/360494f1-57fb-4e13-bc19-0006efe01561"> </p> In addition to the predefined enumerators (`Arabic`, `Alphabet`, `Roman`, `Bullet`, `Tree`), you may also define your own custom enumerator: ```go l := list.New("Duck", "Duck", "Duck", "Duck", "Goose", "Duck", "Duck") func DuckDuckGooseEnumerator(l list.Items, i int) string { if l.At(i).Value() == "Goose" { return "Honk →" } return "" } l = l.Enumerator(DuckDuckGooseEnumerator) ``` Print the list: <p align="center"> <img width="600" alt="image" src="https://github.com/charmbracelet/lipgloss/assets/42545625/157aaf30-140d-4948-9bb4-dfba46e5b87e"> </p> If you need, you can also build lists incrementally: ```go l := list.New() for i := 0; i < repeat; i++ { l.Item("Lip Gloss") } ``` *** <a href="https://charm.sh/"><img alt="The Charm logo" src="https://stuff.charm.sh/charm-badge.jpg" width="400"></a> Thoughts? Questions? We love hearing from you. Feel free to reach out on [Twitter](https://twitter.com/charmcli), [The Fediverse](https://mastodon.technology/@​charm), or on [Discord](https://charm.sh/chat). ### [`v0.11.1`](https://togithub.com/charmbracelet/lipgloss/releases/tag/v0.11.1) [Compare Source](https://togithub.com/charmbracelet/lipgloss/compare/v0.11.0...v0.11.1) This release is a small patch release to fix text truncation in table cells. For details see: [https://github.com/charmbracelet/lipgloss/issues/324](https://togithub.com/charmbracelet/lipgloss/issues/324). #### Other stuff - chore: remove deprecated Copy() calls by [@​meowgorithm](https://togithub.com/meowgorithm) in [https://github.com/charmbracelet/lipgloss/pull/306](https://togithub.com/charmbracelet/lipgloss/pull/306) - feat: deprecate Style.ColorWhitespace by [@​meowgorithm](https://togithub.com/meowgorithm) in [https://github.com/charmbracelet/lipgloss/pull/311](https://togithub.com/charmbracelet/lipgloss/pull/311) - feat: deprecate Style.ColorWhitespace by [@​meowgorithm](https://togithub.com/meowgorithm) in [https://github.com/charmbracelet/lipgloss/pull/314](https://togithub.com/charmbracelet/lipgloss/pull/314) - fix: Deprecate UnsetBorderTopBackgroundColor in favor of UnsetBorderTopBackground by [@​nervo](https://togithub.com/nervo) in [https://github.com/charmbracelet/lipgloss/pull/315](https://togithub.com/charmbracelet/lipgloss/pull/315) **Full Changelog**: charmbracelet/lipgloss@v0.11.0...v0.11.1 *** <a href="https://charm.sh/"><img alt="The Charm logo" src="https://stuff.charm.sh/charm-badge.jpg" width="400"></a> Thoughts? Questions? We love hearing from you. Feel free to reach out on [Twitter](https://twitter.com/charmcli), [The Fediverse](https://mastodon.technology/@​charm), or [Discord](https://charm.sh/discord). </details> <details> <summary>gkampitakis/go-snaps (github.com/gkampitakis/go-snaps)</summary> ### [`v0.5.5`](https://togithub.com/gkampitakis/go-snaps/compare/v0.5.4...v0.5.5) [Compare Source](https://togithub.com/gkampitakis/go-snaps/compare/v0.5.4...v0.5.5) </details> <details> <summary>google/go-containerregistry (github.com/google/go-containerregistry)</summary> ### [`v0.20.1`](https://togithub.com/google/go-containerregistry/releases/tag/v0.20.1) [Compare Source](https://togithub.com/google/go-containerregistry/compare/v0.20.0...v0.20.1) #### What's Changed - Create `remote.Push` by [@​mattmoor](https://togithub.com/mattmoor) in [https://github.com/google/go-containerregistry/pull/1978](https://togithub.com/google/go-containerregistry/pull/1978) **Full Changelog**: google/go-containerregistry@v0.20.0...v0.20.1 ### [`v0.20.0`](https://togithub.com/google/go-containerregistry/releases/tag/v0.20.0) [Compare Source](https://togithub.com/google/go-containerregistry/compare/v0.19.2...v0.20.0) #### What's Changed - Referrer API must return correct Content-Type by [@​GregoireW](https://togithub.com/GregoireW) in [https://github.com/google/go-containerregistry/pull/1968](https://togithub.com/google/go-containerregistry/pull/1968) - 🚨 POTENTIALLY BREAKING: Restore blind-write to remote.Put by [@​jonjohnsonjr](https://togithub.com/jonjohnsonjr) in [https://github.com/google/go-containerregistry/pull/1970](https://togithub.com/google/go-containerregistry/pull/1970) #### New Contributors - [@​GregoireW](https://togithub.com/GregoireW) made their first contribution in [https://github.com/google/go-containerregistry/pull/1968](https://togithub.com/google/go-containerregistry/pull/1968) **Full Changelog**: google/go-containerregistry@v0.19.2...v0.20.0 </details> <details> <summary>owenrumney/go-sarif (github.com/owenrumney/go-sarif/v2)</summary> ### [`v2.3.3`](https://togithub.com/owenrumney/go-sarif/releases/tag/v2.3.3) [Compare Source](https://togithub.com/owenrumney/go-sarif/compare/v2.3.2...v2.3.3) #### What's Changed - fix: Update removed goreleaser flag by [@​kaiwenleee](https://togithub.com/kaiwenleee) in [https://github.com/owenrumney/go-sarif/pull/79](https://togithub.com/owenrumney/go-sarif/pull/79) **Full Changelog**: owenrumney/go-sarif@v2.3.2...v2.3.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on monday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/google/osv-scanner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the spec, https://github.com/opencontainers/distribution-spec/blob/main/spec.md#listing-referrers Content-Type header MUST be set to application/vnd.oci.image.index.v1+json.
This is important as GAR today (OCI 1.0) redirect "referrers" API call to the google console authentication page, and doing so the call return 200 OK + content-type: text/html.
As the test use the registry package it is quite difficult to set a test explicitly on this part.