Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat RestartRequest arguments identical to Launch/Attach arguments #89

Merged
merged 1 commit into from
Feb 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cmd/gentypes/gentypes.go
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ func emitToplevelType(typeName string, descJson json.RawMessage, goTypeIsStruct
} else {
fmt.Fprintf(&b, "\t%s %s `json:\"body,omitempty\"`\n", "Body", bodyTypeName)
}
} else if propName == "arguments" && (typeName == "LaunchRequest" || typeName == "AttachRequest") {
} else if propName == "arguments" && (typeName == "LaunchRequest" || typeName == "AttachRequest" || typeName == "RestartRequest") {
// Special case for LaunchRequest or AttachRequest arguments, which are implementation
// defined and don't have pre-set field names in the specification.
fmt.Fprintln(&b, "\tArguments json.RawMessage `json:\"arguments\"`")
Expand Down Expand Up @@ -563,6 +563,7 @@ var typesExcludeList = map[string]bool{
// Therefore, this type is not used anywhere.
"LaunchRequestArguments": true,
"AttachRequestArguments": true,
"RestartArguments": true,
}

func main() {
Expand Down
7 changes: 1 addition & 6 deletions schematypes.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading