-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'master' into add-security-and-analysis-event
- Loading branch information
Showing
4 changed files
with
122 additions
and
30 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
// Copyright 2023 The go-github AUTHORS. All rights reserved. | ||
// | ||
// Use of this source code is governed by a BSD-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package github | ||
|
||
import ( | ||
"context" | ||
"fmt" | ||
) | ||
|
||
type SecurityAdvisoriesService service | ||
|
||
// RequestCVE requests a Common Vulnerabilities and Exposures (CVE) for a repository security advisory. | ||
// The ghsaID is the GitHub Security Advisory identifier of the advisory. | ||
// | ||
// GitHub API docs: https://docs.github.com/en/rest/security-advisories/repository-advisories#request-a-cve-for-a-repository-security-advisory | ||
func (s *SecurityAdvisoriesService) RequestCVE(ctx context.Context, owner, repo, ghsaID string) (*Response, error) { | ||
url := fmt.Sprintf("repos/%v/%v/security-advisories/%v/cve", owner, repo, ghsaID) | ||
|
||
req, err := s.client.NewRequest("POST", url, nil) | ||
if err != nil { | ||
return nil, err | ||
} | ||
|
||
resp, err := s.client.Do(ctx, req, nil) | ||
if err != nil { | ||
if _, ok := err.(*AcceptedError); ok { | ||
return resp, nil | ||
} | ||
|
||
return resp, err | ||
} | ||
|
||
return resp, nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
// Copyright 2023 The go-github AUTHORS. All rights reserved. | ||
// | ||
// Use of this source code is governed by a BSD-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package github | ||
|
||
import ( | ||
"context" | ||
"net/http" | ||
"testing" | ||
) | ||
|
||
func TestSecurityAdvisoriesService_RequestCVE(t *testing.T) { | ||
client, mux, _, teardown := setup() | ||
defer teardown() | ||
|
||
mux.HandleFunc("/repos/o/r/security-advisories/ghsa_id_ok/cve", func(w http.ResponseWriter, r *http.Request) { | ||
testMethod(t, r, "POST") | ||
w.WriteHeader(http.StatusOK) | ||
}) | ||
|
||
mux.HandleFunc("/repos/o/r/security-advisories/ghsa_id_accepted/cve", func(w http.ResponseWriter, r *http.Request) { | ||
testMethod(t, r, "POST") | ||
w.WriteHeader(http.StatusAccepted) | ||
}) | ||
|
||
ctx := context.Background() | ||
_, err := client.SecurityAdvisories.RequestCVE(ctx, "o", "r", "ghsa_id_ok") | ||
if err != nil { | ||
t.Errorf("SecurityAdvisoriesService.RequestCVE returned error: %v", err) | ||
} | ||
|
||
_, err = client.SecurityAdvisories.RequestCVE(ctx, "o", "r", "ghsa_id_accepted") | ||
if err != nil { | ||
t.Errorf("SecurityAdvisoriesService.RequestCVE returned error: %v", err) | ||
} | ||
|
||
const methodName = "RequestCVE" | ||
testBadOptions(t, methodName, func() (err error) { | ||
_, err = client.SecurityAdvisories.RequestCVE(ctx, "\n", "\n", "\n") | ||
return err | ||
}) | ||
|
||
testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) { | ||
resp, err := client.SecurityAdvisories.RequestCVE(ctx, "o", "r", "ghsa_id") | ||
if err == nil { | ||
t.Errorf("testNewRequestAndDoFailure %v should have return err", methodName) | ||
} | ||
return resp, err | ||
}) | ||
} |