Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star event is missing events #1868

Closed
jloh opened this issue May 7, 2021 · 2 comments · Fixed by #1869
Closed

Star event is missing events #1868

jloh opened this issue May 7, 2021 · 2 comments · Fixed by #1869
Assignees

Comments

@jloh
Copy link
Contributor

jloh commented May 7, 2021

Hi all. The Star event is missing the sender, repository and organization fields that come in the webhook payload from GitHub:

// StarEvent is triggered when a star is added or removed from a repository.
// The Webhook event name is "star".
//
// GitHub API docs: https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#star
type StarEvent struct {
// Action is the action that was performed. Possible values are: "created" or "deleted".
Action *string `json:"action,omitempty"`
// StarredAt is the time the star was created. It will be null for the "deleted" action.
StarredAt *Timestamp `json:"starred_at,omitempty"`
}

I'm happy to make the changes to this type myself if a PR would be accepted.

Thanks for the excellent library! It does absolutely everything!

@gmlewis
Copy link
Collaborator

gmlewis commented May 7, 2021

Thank you, @jloh !
It is yours. 😁

@gmlewis
Copy link
Collaborator

gmlewis commented May 7, 2021

If this is your first PR, please read through our CONTRIBUTING.md document.

jloh added a commit to jloh/go-github that referenced this issue May 7, 2021
gmlewis pushed a commit that referenced this issue May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants