Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golang.org/x/crypto/openpgp is deprecated #2317

Closed
cablehead opened this issue Mar 22, 2022 · 2 comments · Fixed by #2666
Closed

golang.org/x/crypto/openpgp is deprecated #2317

cablehead opened this issue Mar 22, 2022 · 2 comments · Fixed by #2666

Comments

@cablehead
Copy link

golang.org/x/crypto/openpgp is currently used to as an optional signing key: https://github.com/google/go-github/blob/master/github/git_commits.go#L27-L50

However this package is now deprecated: golang/go#44226
@hungle92
Copy link

hungle92 commented Feb 7, 2023

Looks like 0.5.0 is released in the following link:
https://pkg.go.dev/golang.org/x/crypto#readme-download-install

It would resolve: CVE-2022-27191

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 7, 2023

@hungle92 - would you like to submit a PR?

@komod0 komod0 mentioned this issue Feb 18, 2023
Merged
gmlewis pushed a commit that referenced this issue Mar 8, 2023
@komod0
Move to Protonmail PGP (#2666)
8e34527 
Fixes: #2317.
exageraldo pushed a commit to exageraldo/go-github that referenced this issue Mar 13, 2023
@komod0 @exageraldo
Move to Protonmail PGP (google#2666)
14e1132 
Fixes: google#2317.
@gmlewis gmlewis mentioned this issue Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move to Protonmail PGP komod0/go-github
3 participants
@cablehead @gmlewis @hungle92