-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update apps.go #1238
Merged
Merged
Update apps.go #1238
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b91a2a6
Update apps.go
emoryruscus d0834e0
Update apps_test.go
emoryruscus 0d94311
Update apps.go - Change 'parameters' to 'options'
emoryruscus ad7cafc
Update apps_test.go
emoryruscus 243b6b0
Update apps_test.go
emoryruscus 89c7ea2
Update github-accessors.go
emoryruscus 431e8e6
Update github-accessors.go
emoryruscus bc6f117
Update github-accessors.go
emoryruscus 96f8146
gofmt spacing fix
emoryruscus d00e1b1
Update apps.go
emoryruscus 040e921
gofmt spacing fix2
emoryruscus 24ee2e6
Move reader functions for coverage test.
emoryruscus d069332
Move reader functions for coverage test.
emoryruscus 9a57f54
Update apps.go
emoryruscus 14c5f86
Update apps_test.go
emoryruscus 6289bf9
parent c756c329c19dbbadba0675b42af693093c3f2c45
emoryruscus 5033cff
Merge branch 'patch-1' of https://github.com/emoryruscus/go-github in…
emoryruscus 9d6fd70
Update apps.go
emoryruscus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I much prefer these two new helper functions be used for testing only... thank you!
In fact, since they are rather general purpose, I would be fine to move them to
github_test.go
if you want, or we could just leave them here for now and move them in a later PR if they become more generally used.We'll see what @gauntface thinks about them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome! Will leave them here for now if that is alright.