Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change opt param to opts #1417

Merged
merged 3 commits into from
Feb 10, 2020
Merged

Change opt param to opts #1417

merged 3 commits into from
Feb 10, 2020

Conversation

kadern0
Copy link
Contributor

@kadern0 kadern0 commented Feb 10, 2020

Fixes #1415

pcaderno and others added 3 commits February 10, 2020 11:28
@pcaderno
Changed "opt" param names to "opts"
cef58be 
Fixes google#1415

Signed-off-by: Pablo Caderno <kaderno@gmail.com>
@kadern0 @pcaderno
Changed "opt" param names to "opts"
467aade 
Fixes google#1415

Signed-off-by: Pablo Caderno <kaderno@gmail.com>
@pcaderno
Merge branch 'change_opt_param_to_opts' of https://github.com/kadern0…
00c5baf 
…/go-github into change_opt_param_to_opts
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@kadern0
Copy link
Contributor Author

kadern0 commented Feb 10, 2020

@googlebot I fixed it.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Feb 10, 2020
gmlewis
gmlewis approved these changes Feb 10, 2020
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kadern0!
LGTM.
Merging.

@gmlewis gmlewis merged commit 6923131 into google:master Feb 10, 2020
This was referenced Feb 10, 2020
Merged
Merged
Merged
@kadern0
Copy link
Contributor Author

kadern0 commented Feb 10, 2020

Happy to help and sorry for the mess with the commits!

@kadern0 kadern0 deleted the change_opt_param_to_opts branch February 10, 2020 01:21
@gmlewis
Copy link
Collaborator

gmlewis commented Feb 10, 2020

No problem... I didn't even notice! 😄

We always "squash and merge" in this repo, so it doesn't matter how many commits a PR takes to get right... just the final version counts. 😄

@gmlewis gmlewis mentioned this pull request Feb 12, 2020
Merged
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
@kadern0
Change opt param to opts (google#1417)
c7912f5 
Fixes google#1415.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change "opt" param names to "opts" everywhere to make the repo consistent
4 participants
@kadern0 @googlebot @gmlewis @pcaderno