Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apps-Service: Add baptiste-preview to ListRepos and ListUserRepos #1860

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Apps-Service: Add baptiste-preview to ListRepos and ListUserRepos #1860

merged 1 commit into from
Apr 27, 2021

Conversation

andygrunwald
Copy link
Contributor

The preview application/vnd.github.baptiste-preview+json ensures that the field "is_template": false is part of the repository response of the Apps Service.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Apr 27, 2021
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #1860 (80485d5) into master (cceb4d4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1860   +/-   ##
=======================================
  Coverage   97.64%   97.65%           
=======================================
  Files         105      105           
  Lines        6764     6770    +6     
=======================================
+ Hits         6605     6611    +6     
  Misses         86       86           
  Partials       73       73           
Impacted Files Coverage Δ
github/apps_installation.go 92.30% <100.00%> (+1.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cceb4d4...80485d5. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @andygrunwald !
LGTM.

Awaiting second LGTM before merging.

@gmlewis gmlewis requested a review from wesleimp April 27, 2021 17:30
Copy link
Collaborator

@wesleimp wesleimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💙

@gmlewis
Copy link
Collaborator

gmlewis commented Apr 27, 2021

Thank you, @wesleimp !
Merging.

@gmlewis gmlewis merged commit 9d6877c into google:master Apr 27, 2021
This was referenced May 21, 2021
This was referenced Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants