-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align Installation Permissions to latest GitHub v3 API reference #1880
Align Installation Permissions to latest GitHub v3 API reference #1880
Conversation
* Update document URL in comment * Add support for environments, organization_secrets, organization_self_hosted_runners, secrets, secret_scanning_alerts, security_events and workflows * Align test code with new fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @xun-guo-anzx !
Please run go generate ./...
and then push (please do not force push) the commit to this PR to make the tests pass (as described in our CONTRIBUTING.md
document).
Thanks @gmlewis for looking into this. I've run |
Codecov Report
@@ Coverage Diff @@
## master #1880 +/- ##
=======================================
Coverage 97.65% 97.65%
=======================================
Files 105 105
Lines 6783 6783
=======================================
Hits 6624 6624
Misses 86 86
Partials 73 73
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @xun-guo-anzx !
LGTM.
Awaiting second LGTM before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💙
Thank you, @wesleimp ! |
@gmlewis Would it be possible to create a new release? Thanks! |
Certainly! Here you go: https://github.com/google/go-github/releases/tag/v35.3.0 |
This PR is to fix issue #1879 by updating InstallationPermissions struct with new properties included in API Document.
Changes include: