-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow empty selected_repository_ids for SetSelectedReposForOrgSecret #2036
Allow empty selected_repository_ids for SetSelectedReposForOrgSecret #2036
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2036 +/- ##
=======================================
Coverage 97.87% 97.87%
=======================================
Files 107 107
Lines 6907 6907
=======================================
Hits 6760 6760
Misses 81 81
Partials 66 66
Continue to review full report at Codecov.
|
The GitHub v3 API docs for this endpoint state:
Am I reading this correctly that this endpoint should simply not be called when I ask because I'm trying to figure out if there is any case when you would want to call this endpoint but NOT send a value for |
Yes - this endpoint should simply not be called when
My use case for calling this endpoint without sending a value for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @xun-guo-anzx !
LGTM.
Merging.
Thanks @gmlewis , may I request a release for this change? |
Sure, I'll get you a release. |
Fix #2035 - Allow empty selected_repository_ids for SetSelectedReposForOrgSecret