-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for User SSH signing keys #2482
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @neersighted !
LGTM.
Awaiting second LGTM from any other contributor to this repo before merging.
0dcd9f3
to
188b59b
Compare
188b59b
to
c3c2c61
Compare
@neersighted - please use regular push of commits to this PR and not force push, as it makes it really challenging for the reviewer to see what changes each time. We always use squash and merge in this repo anyway so it doesn't matter how many commits it takes. Thank you. |
Codecov Report
@@ Coverage Diff @@
## master #2482 +/- ##
==========================================
- Coverage 98.03% 97.99% -0.05%
==========================================
Files 122 123 +1
Lines 10705 10762 +57
==========================================
+ Hits 10495 10546 +51
- Misses 144 148 +4
- Partials 66 68 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Fair -- I'm usually used to a "clean history" workflow -- in this case |
Thank you, @valbeat ! |
Introduce support for the new SSH signing key endpoints introduced into the REST API with the introduction of SSH commit verification.