-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RunAttempt field for WorkflowJob #2562
Add RunAttempt field for WorkflowJob #2562
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@gmlewis Can you pls check if this can go live? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @paveldvoinos , and I apologize for letting this one slip through the cracks.
Thanks also for the reminder, I appreciate it.
LGTM.
Merging.
Whups, it looks like the modified files need |
Codecov Report
@@ Coverage Diff @@
## master #2562 +/- ##
=======================================
Coverage 97.98% 97.98%
=======================================
Files 125 125
Lines 10875 10875
=======================================
Hits 10656 10656
Misses 150 150
Partials 69 69
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@gmlewis I tried and Also ,I have concerns that the linting check itself is broken: this is the error the step fails with:
|
Yes, it looks like we need to use It looks like |
Hmmm... we are already using the latest version: https://github.com/golangci/golangci-lint-action/releases/tag/v3.3.1 You ran |
yes, generated files included |
@paveldvoinos - could you please |
…e/go-github into add-workflow-job-run-attempt
That worked! Merging. Thank you for your patience, @paveldvoinos ! |
Add RunAttempt field for WorkflowJob