Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support line comments on PRs #2833

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Support line comments on PRs #2833

merged 2 commits into from
Jul 18, 2023

Conversation

varmakarthik12
Copy link
Contributor

@varmakarthik12 varmakarthik12 commented Jul 18, 2023

@google-cla
Copy link

google-cla bot commented Jul 18, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewis gmlewis changed the title feat(2832): Implement's line comments on PR's Support line comments on PRs Jul 18, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Jul 18, 2023

Please run go generate ./... and push (not force-push) the changes to this PR.
See CONTRIBUTING.md for details.

@varmakarthik12
Copy link
Contributor Author

Please run go generate ./... and push (not force-push) the changes to this PR. See CONTRIBUTING.md for details.

My Bad, This should be good now. LMK.

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #2833 (c23b77d) into master (6c1dedd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2833   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         137      137           
  Lines       12289    12289           
=======================================
  Hits        12051    12051           
  Misses        162      162           
  Partials       76       76           
Impacted Files Coverage Δ
github/pulls_comments.go 100.00% <ø> (ø)

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @varmakarthik12 !
LGTM.
Merging.

@gmlewis gmlewis merged commit d783bb1 into google:master Jul 18, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants