-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add List Installation Requests API #2947
Add List Installation Requests API #2947
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Signed CLA and rescanned. |
Codecov Report
@@ Coverage Diff @@
## master #2947 +/- ##
==========================================
- Coverage 98.19% 98.17% -0.03%
==========================================
Files 145 145
Lines 12720 12735 +15
==========================================
+ Hits 12490 12502 +12
- Misses 156 158 +2
- Partials 74 75 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @abhijit-hota !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Thanks, @gmlewis. I see that the coverage has decreased somehow. Can I do anything about it? |
I don't think so, because it is harder to test the endpoints that take no parameters in the URL itself... as we can't corrupt it as easily... so I'm not worried about the dropping code coverage in this case. Thank you for checking, though, @abhijit-hota ! It is appreciated. ❤️ |
Thank you, @WillAbides ! |
@gmlewis Thank you for the prompt review and merge! Is there any tentative release date for this? |
Hi @gmlewis, I see that the above PRs have been merged! We're currently using the master branch and would prefer to shift to a pinned release. Thanks! |
@abhijit-hota - this has now been included in the latest release: |
Thanks for the quick response again, @gmlewis! |
The PR adds support for listing installation requests for the authenticated app.