Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc for NewPullRequest #3208

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

kevinburkesegment
Copy link
Contributor

I recently mixed up "Head" and "Base" and the error message was not clear. Add some guidance to help people avoid making the same mistake.

This is copied word for word from the existing Github docs.

I recently mixed up "Head" and "Base" and the error message was not
clear. Add some guidance to help people avoid making the same mistake.

This is copied word for word from the existing Github docs.
Copy link

google-cla bot commented Jul 15, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.92%. Comparing base (2b8c7fa) to head (f6299f1).
Report is 82 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3208      +/-   ##
==========================================
- Coverage   97.72%   92.92%   -4.80%     
==========================================
  Files         153      171      +18     
  Lines       13390    11582    -1808     
==========================================
- Hits        13085    10763    -2322     
- Misses        215      726     +511     
- Partials       90       93       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis
Copy link
Collaborator

gmlewis commented Jul 16, 2024

Thank you, @kevinburkesegment - would you like to sign the CLA so that I can merge this, or would you prefer I open up a separate PR and copy the original text from the official GitHub documentation into that one instead?

@kevinburkesegment
Copy link
Contributor Author

I believe I signed the CLA but if you're still not seeing it on your end please feel free to duplicate the work. I do not need credit, I'd just like it to be fixed so I don't make the same mistake 6 months from now. Thanks

@gmlewis gmlewis changed the title github: add doc for NewPullRequest Add doc for NewPullRequest Jul 16, 2024
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I signed the CLA but if you're still not seeing it on your end please feel free to duplicate the work. I do not need credit, I'd just like it to be fixed so I don't make the same mistake 6 months from now. Thanks

Excellent, thank you, @kevinburkesegment !
LGTM.
Merging.

@gmlewis gmlewis merged commit 5f496dd into google:master Jul 16, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants