Add Webhook for Repository ruleset #3298
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
gmlewis
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3298 +/- ##
==========================================
- Coverage 97.72% 93.05% -4.67%
==========================================
Files 153 172 +19
Lines 13390 11772 -1618
==========================================
- Hits 13085 10955 -2130
- Misses 215 723 +508
- Partials 90 94 +4 ☔ View full report in Codecov by Sentry. |
unamdev0
force-pushed
the
feature/add-repository-ruleset-webhook-even
branch
from
de359f4
to
a872d15
Compare
| @@ -1505,6 +1505,20 @@ type RepositoryImportEvent struct { | |||
| Sender *User `json:"sender,omitempty"` | |||
| } | |||
|
|
|||
| // RepositoryRuleSetEvent event occurs when there is activity relating to repository rulesets | |||
There was a problem hiding this comment.
Godocs should always use complete sentences with punctuation so that the auto-generated package documentation formats and reads nicely.
Also, we should match the capitalization that GitHub uses for "ruleset" so everywhere that you wrote "RuleSet" it should instead be "Ruleset".
| // RepositoryRuleSetEvent event occurs when there is activity relating to repository rulesets | |
| // RepositoryRulesetEvent event occurs when there is activity relating to repository rulesets. |
| // RepositoryRuleSetEvent event occurs when there is activity relating to repository rulesets | ||
| // | ||
| // GitHub API docs: https://docs.github.com/en/webhooks/webhook-events-and-payloads#repository_ruleset | ||
| type RepositoryRuleSetEvent struct { |
There was a problem hiding this comment.
| type RepositoryRuleSetEvent struct { | |
| type RepositoryRulesetEvent struct { |
| Installation *Installation `json:"installation,omitempty"` | ||
| Organization *Organization `json:"organization,omitempty"` | ||
| Repository *Repository `json:"repository,omitempty"` | ||
| RepositoryRuleSet *RepositoryRuleSet `json:"repository_ruleset"` |
There was a problem hiding this comment.
| RepositoryRuleSet *RepositoryRuleSet `json:"repository_ruleset"` | |
| RepositoryRuleset *RepositoryRuleset `json:"repository_ruleset"` |
| Organization *Organization `json:"organization,omitempty"` | ||
| Repository *Repository `json:"repository,omitempty"` | ||
| RepositoryRuleSet *RepositoryRuleSet `json:"repository_ruleset"` | ||
| Changes *RepositoryRuleSetEditedChanges `json:"changes,omitempty"` |
There was a problem hiding this comment.
| Changes *RepositoryRuleSetEditedChanges `json:"changes,omitempty"` | |
| Changes *RepositoryRulesetEditedChanges `json:"changes,omitempty"` |
| @@ -9448,6 +9448,1782 @@ func TestReleaseEvent_Marshal(t *testing.T) { | |||
| testJSONMarshal(t, u, want) | |||
| } | |||
|
|
|||
| func TestRepositoryRuleSetEvent_Marshal(t *testing.T) { | |||
There was a problem hiding this comment.
| func TestRepositoryRuleSetEvent_Marshal(t *testing.T) { | |
| func TestRepositoryRulesetEvent_Marshal(t *testing.T) { |
| @@ -9448,6 +9448,1782 @@ func TestReleaseEvent_Marshal(t *testing.T) { | |||
| testJSONMarshal(t, u, want) | |||
| } | |||
|
|
|||
| func TestRepositoryRuleSetEvent_Marshal(t *testing.T) { | |||
| testJSONMarshal(t, &RepositoryRuleSetEvent{}, "{}") | |||
There was a problem hiding this comment.
| testJSONMarshal(t, &RepositoryRuleSetEvent{}, "{}") | |
| testJSONMarshal(t, &RepositoryRulesetEvent{}, "{}") |
|
|
||
| jsonMsg, _ := json.Marshal(&l) | ||
|
|
||
| u := &RepositoryRuleSetEvent{ |
There was a problem hiding this comment.
I'll stop making suggestions for these, but we should change them all to be consistent with GitHub's documentation.
| u := &RepositoryRuleSetEvent{ | |
| u := &RepositoryRulesetEvent{ |
|
Please do NOT use force-push as described in CONTRIBUTING.md, especially on large PRs like this one, since that makes it extremely difficult for the reviewer to see what has changed since the last review. Thanks. |
Oh, I didn't I just rebased it, will make all the changes suggested and will let you know |
Added Webhook for Repository ruleset