Remove dependency on gen to generate sets #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itchyny
force-pushed
the
refactor-remove-gen-dependency
branch
from
bd22137 to
12d1600
Compare
itchyny
force-pushed
the
refactor-remove-gen-dependency
branch
from
12d1600 to
f5dcaa6
Compare
|
Yeah, we should avoid using codegen like this. (We still want codegen for stdlib AST - to avoid parsing overhead on startup, but that's maintained by us and less hairy). |
itchyny
added a commit
to itchyny/go-jsonnet
that referenced
this pull request
Jun 10, 2024
sbarzowski
pushed a commit
that referenced
this pull request
Jun 10, 2024
* chore: update rules_go and gazelle version to fix bazel build * chore: fix source file list in ast directory (ref: #746) * chore: fix dependency list in formatter directory
vhata
pushed a commit
to discord/go-jsonnet
that referenced
this pull request
Aug 30, 2024
vhata
pushed a commit
to discord/go-jsonnet
that referenced
this pull request
Aug 30, 2024
…#756) * chore: update rules_go and gazelle version to fix bazel build * chore: fix source file list in ast directory (ref: google#746) * chore: fix dependency list in formatter directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously back in 2017, the set implementations stopped updating due to #95. This PR looks a bit thoughtless, and we should decide how to deal with the code generated by gen. As for now, https://github.com/clipperhouse/gen has been deprecated, and also https://github.com/clipperhouse/set has been renamed to
setwriter. Right now the commandmake install.dependenciesdoes not work in Go 1.22, becausego getno longer supports legacyGOPATHmode (see https://tip.golang.org/doc/go1.22#go-command). The set implementations are straightforward, so I would like to suggest to stop using thegentool to generate set types.