-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting functionalities for direct migration #283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One idea worth considering here is which direction we want to support conversion for the TPM types. We can support:
- Using the new TPM type (
transport.TPM
) with the old TPM interface (io.ReadWriter
/io.ReadWriteCloser
) and library. - Using the old TPM type (
io.ReadWriter
) with the new TPM interface (transport.TPM
) and library
This PR implements (2), but I'm wondering if we should implement (1) instead.
This PR implements 2 because the old tests still need RWC and the Direct Migration needs a RW in order to be made a transport tpm used for Execute. Correct me if I'm wrong but eventually we will only have 1 interface. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matt-tsai let us know when this is ready for review again (and the TODO comments are cleaned up).
Added and changed names of private Types and return types of OpenTPM.
9c2c18c
to
63fd70e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change, looks great. Only teeny nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the Read implementation, LGTM
35859f1
to
a3e0580
Compare
Nice work on this!!! |
Main changes include: ReadWrite interface for transport TPMs, adding util to grab HandleValue.