Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented and Tested PolicyPCR #289

Merged
merged 3 commits into from
Jul 12, 2022
Merged

Implemented and Tested PolicyPCR #289

merged 3 commits into from
Jul 12, 2022

Conversation

matt-tsai
Copy link
Contributor

Finished implementing PolicyPCR. Covered positive, negative, and void test cases.

@matt-tsai matt-tsai requested a review from a team as a code owner July 6, 2022 23:40
chrisfenner
chrisfenner reviewed Jul 6, 2022
View reviewed changes
direct/tpm2/tpm2.go Outdated Show resolved Hide resolved
matt-tsai
matt-tsai commented Jul 6, 2022
View reviewed changes
direct/tpm2/policy_test.go Outdated Show resolved Hide resolved
chrisfenner
chrisfenner requested changes Jul 7, 2022
View reviewed changes
direct/tpm2/policy_test.go Outdated Show resolved Hide resolved
direct/tpm2/policy_test.go Outdated Show resolved Hide resolved
direct/tpm2/policy_test.go Outdated Show resolved Hide resolved
direct/tpm2/policy_test.go Show resolved Hide resolved
alexmwu
alexmwu reviewed Jul 8, 2022
View reviewed changes
direct/tpm2/policy_test.go Outdated Show resolved Hide resolved
direct/tpm2/policy_test.go Outdated Show resolved Hide resolved
direct/tpm2/policy_test.go Outdated Show resolved Hide resolved
chrisfenner
chrisfenner requested changes Jul 8, 2022
View reviewed changes
Copy link
Member

@chrisfenner chrisfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good. Thanks for your thoroughness! I have a few more nits (sorry) and one comment about TestPolicyPCRUpdate's negative test case.

direct/tpm2/policy_test.go Show resolved Hide resolved
direct/tpm2/policy_test.go Outdated Show resolved Hide resolved
direct/tpm2/policy_test.go Outdated Show resolved Hide resolved
direct/tpm2/policy_test.go Outdated Show resolved Hide resolved
direct/tpm2/policy_test.go Outdated Show resolved Hide resolved
direct/tpm2/policy_test.go Outdated Show resolved Hide resolved
chrisfenner
chrisfenner approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@chrisfenner chrisfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! I have some very minor (some optional) nits and then I think we're ready to merge this in.

direct/tpm2/policy_test.go Outdated Show resolved Hide resolved
direct/tpm2/policy_test.go Show resolved Hide resolved
direct/tpm2/policy_test.go Outdated Show resolved Hide resolved
direct/tpm2/policy_test.go Outdated Show resolved Hide resolved
direct/tpm2/policy_test.go Outdated Show resolved Hide resolved
direct/tpm2/policy_test.go Outdated Show resolved Hide resolved
@chrisfenner chrisfenner merged commit d20ef6e into google:tpmdirect Jul 12, 2022
@matt-tsai matt-tsai deleted the PolicyPCR branch July 12, 2022 20:14
@matt-tsai matt-tsai changed the title PolicyPCR Implemented and Tested PolicyPCR Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephlr josephlr josephlr left review comments

@alexmwu alexmwu alexmwu left review comments

@chrisfenner chrisfenner chrisfenner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matt-tsai @alexmwu @josephlr @chrisfenner