Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KnownName() and Empty Buffer sequence handle Names #371

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Fix KnownName() and Empty Buffer sequence handle Names #371

merged 4 commits into from
Sep 20, 2024

Conversation

nckrss
Copy link
Contributor

@nckrss nckrss commented Sep 20, 2024

This PR resolves a bug introduced to KnownName handling and introduces a struct tag for commands that allow for the Name to be the Empty Buffer, namely TPM2_SequenceUpdate and TPM2_SequenceComplete.

  • Add tests for multiple transient objects in an HMAC sequence
  • Handle special case for sequence object handle Name fields
  • Relax HmacStart.Handle type from AuthHandle to handle
  • Fix prior RSA test that silently succeeded due to KnownName() bug

Fixes #370

@nckrss nckrss requested review from alexmwu, jkl73 and a team as code owners September 20, 2024 14:39
@chrisfenner
Copy link
Member

Thank you so much for the bug report and the accompanying fix, @nckrss!

@chrisfenner chrisfenner merged commit 364d5f2 into google:main Sep 20, 2024
4 checks passed
@nckrss nckrss deleted the 370-bugfix-knownname-and-sequence-names branch September 20, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisfenner chrisfenner chrisfenner approved these changes

@alexmwu alexmwu Awaiting requested review from alexmwu alexmwu is a code owner

@jkl73 jkl73 Awaiting requested review from jkl73 jkl73 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid handling of KnownName() and Empty Buffer responses
2 participants
@nckrss @chrisfenner