Improve crypto & constants #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandreEXFO
requested review from
alexmwu,
jkl73 and
a team
as code owners
chrisfenner
requested changes
Dec 16, 2024
There was a problem hiding this comment.
Thanks for this work! I have just one nit to pick about naming, then we can merge. I am also working on some testing for this code that uses TPM2_Duplicate to check that we get valid/compatible private and public keys out of this code. I'll integrate my changes atop yours.
tpm2/constants.go
Outdated
| TPMECCBNP256 TPMECCCurve = 0x0010 | ||
| TPMECCBNP638 TPMECCCurve = 0x0011 | ||
| TPMECCSM2P256 TPMECCCurve = 0x0020 | ||
| TPMECCBrainpool_P256_R1 TPMECCCurve = 0x0030 |
There was a problem hiding this comment.
nit: Current style is to omit underscores from the names (even though that can lead to initialisms being next to each other) in accordance with Google's general Go style guide
chrisfenner
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.