Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Pub() and Priv() by exporting the key and signing/verifying from software #382

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

chrisfenner
Copy link
Member

@chrisfenner chrisfenner commented Dec 16, 2024

This PR enhances the crypto_test.go unit-test by adding a test that creates a TPM key, exports it, and then checks that TPM and software can mutually sign/verify one another.

@chrisfenner chrisfenner changed the title Add round-trip duplicate/import tests that exercise Pub and Priv Test Pub() and Priv() by exporting the key and signing/verifying from software Dec 16, 2024
@chrisfenner
Copy link
Member Author

+CC @AlexandreEXFO in case you have comments on this one.

@chrisfenner chrisfenner marked this pull request as ready for review December 16, 2024 21:30
@chrisfenner chrisfenner requested review from alexmwu, jkl73 and a team as code owners December 16, 2024 21:30
@AlexandreEXFO
Copy link
Contributor

@chrisfenner : There are errors in the error messages of the TestRoundTrip function since there are RSA and ECC keys. Otherwise, it's good.

By curiosity, do you plan to make a new version soon with the changes? I would like to stop depending on a fork for a project that uses this library.

@chrisfenner
Copy link
Member Author

@chrisfenner : There are errors in the error messages of the TestRoundTrip function since there are RSA and ECC keys. Otherwise, it's good.

By curiosity, do you plan to make a new version soon with the changes? I would like to stop depending on a fork for a project that uses this library.

Thank you! I will kick off another release after this PR goes in.

tpm2/crypto_test.go Outdated Show resolved Hide resolved
@chrisfenner chrisfenner merged commit a21381d into google:main Dec 17, 2024
4 checks passed
@chrisfenner
Copy link
Member Author

@chrisfenner : There are errors in the error messages of the TestRoundTrip function since there are RSA and ECC keys. Otherwise, it's good.
By curiosity, do you plan to make a new version soon with the changes? I would like to stop depending on a fork for a project that uses this library.

Thank you! I will kick off another release after this PR goes in.

https://github.com/google/go-tpm/releases/tag/v0.9.3

@chrisfenner chrisfenner deleted the add-round-trip branch December 18, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants