Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[googletest] Output skip message #2517

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Conversation

snarkmaster
Copy link
Contributor

Closes #2208

Previously, skip messages were invisible, so debugging skips was hard.

Now we have this:

$ ./googletest/gtest_skip_test
Running main() from /home/lesha/github/snarkmaster/googletest/googletest/src/gtest_main.cc
[==========] Running 3 tests from 2 test suites.
[----------] Global test environment set-up.
[----------] 1 test from SkipTest
[ RUN      ] SkipTest.DoesSkip
/home/lesha/github/snarkmaster/googletest/googletest/test/gtest_skip_test.cc:38: Skipped
skipping single test
[  SKIPPED ] SkipTest.DoesSkip (0 ms)
[----------] 1 test from SkipTest (1 ms total)
...

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Closes google#2208

Previously, skip messages were invisible, so debugging skips was hard.

Now we have this:

```
$ ./googletest/gtest_skip_test
Running main() from /home/lesha/github/snarkmaster/googletest/googletest/src/gtest_main.cc
[==========] Running 3 tests from 2 test suites.
[----------] Global test environment set-up.
[----------] 1 test from SkipTest
[ RUN      ] SkipTest.DoesSkip
/home/lesha/github/snarkmaster/googletest/googletest/test/gtest_skip_test.cc:38: Skipped
skipping single test
[  SKIPPED ] SkipTest.DoesSkip (0 ms)
[----------] 1 test from SkipTest (1 ms total)
...
```
@snarkmaster
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@asoffer
Copy link
Contributor

asoffer commented Oct 17, 2019

Looks good. Pulling this internally!

gennadiycivil added a commit that referenced this pull request Oct 21, 2019
PiperOrigin-RevId: 275869169
gennadiycivil added a commit that referenced this pull request Oct 21, 2019
PiperOrigin-RevId: 275869169
gennadiycivil added a commit that referenced this pull request Oct 21, 2019
PiperOrigin-RevId: 275869169
gennadiycivil added a commit that referenced this pull request Oct 22, 2019
PiperOrigin-RevId: 275869169
@gennadiycivil gennadiycivil merged commit cbf019d into google:master Oct 22, 2019
facebook-github-bot pushed a commit to facebook/folly that referenced this pull request Oct 23, 2019
Summary:
Until [very recently](google/googletest#2517), `googletest` did not print the skip message in any shape or form, so nothing can possibly depend on us customizing the skip message here.

The default is perfectly fine, let's keep it simple.

Reviewed By: yfeldblum

Differential Revision: D18051635

fbshipit-source-id: f7b889b0adf5e34a70c2579a34748bb159809b3c
tchaikov added a commit to tchaikov/ceph that referenced this pull request Jan 22, 2020
to include the fix for
google/googletest#2517

Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov added a commit to tchaikov/ceph that referenced this pull request Jan 22, 2020
to include the fix for
google/googletest#2517

Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov added a commit to tchaikov/ceph that referenced this pull request May 25, 2021
to include the fix for
google/googletest#2517

Signed-off-by: Kefu Chai <kchai@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GTEST_SKIP() << {message} doesn't output message when executed from SetUp() fixtures
4 participants