Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the tutorial that may be confusing #3008

Merged
merged 5 commits into from Nov 3, 2020
Merged

Improve the tutorial that may be confusing #3008

merged 5 commits into from Nov 3, 2020

Conversation

ghost
Copy link

@ghost ghost commented Sep 14, 2020

This patch updates the tutorial which can be confusing for users
This issue has been raised by the users from

#2950

I tried minimize the revision because I don't know exactly what the previous writer intended
and so almost all of the original contents have been preserved

@google-cla google-cla bot added the cla: yes label Sep 14, 2020
Copy link

@romanwerpachowski romanwerpachowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

googletest/README.md Show resolved Hide resolved
Copy link

@romanwerpachowski romanwerpachowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's a great improvement.

@vslashg
Copy link
Member

vslashg commented Sep 15, 2020

This looks good, but could you revert the changes adding a space between "GoogleTest" and "GoogleMock"? I know we're inconsistent with this spelling in places, but we prefer to spell these as one word.

@ghost
Copy link
Author

ghost commented Sep 15, 2020

@vslashg

As I modified googletest/README.md,
I couldn't avoid to modify other two files for consistency (README.md, googlemock/README.md).
(even though there are still some inconsistencies)

I know that it must be very cautious to revise the main title, and titles.
but for now, I uploaded a patch which includes those changes.

Please let me know if there are any parts that should remain not modified.

suertreus added a commit that referenced this pull request Nov 3, 2020
@suertreus suertreus merged commit fb98f74 into google:master Nov 3, 2020
@ghost ghost deleted the update_tutorial branch July 28, 2021 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants