CMake: Add namespaced ALIAS library #3155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bell-2319
approved these changes
Dec 5, 2020
|
Looks good! |
ghost
mentioned this pull request
|
should also close #2429 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3125
I've assumed that #3094 will be in shortly, and so there's no need to guard this like in other places, for example:
googletest/googletest/cmake/internal_utils.cmake
Line 178 in 93748a9
I've also had to make sure
cmake_package_nameis always set so that the namespace is consistent between exported targets and the alias libraries.