-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace JSON schema with proto > Firestore converter #1787
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gino-m
force-pushed
the
gino-m/1758/add-proto-model
branch
from
May 16, 2024 16:07
d21a080
to
9564d95
Compare
…to gino-m/1758/add-proto-model
gino-m
changed the title
Implement shared lib with proto converters for web and Cloud Functions
Implement proto<>Firestore converter lib
May 28, 2024
gino-m
changed the title
Implement proto<>Firestore converter lib
Replace JSON schema with proto<>Firestore converter lib
May 28, 2024
gino-m
changed the title
Replace JSON schema with proto<>Firestore converter lib
Replace JSON schema with proto > Firestore converter
May 28, 2024
rfontanarosa
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements conversion of base cases in one direction only (towards #1758) and cleans up remnants of JSON schema experiment (Closes #1698).