Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Create/edit survey] Write using new proto-based Firestore representation #1869

Merged
merged 40 commits into from
Jun 28, 2024
Merged

[Create/edit survey] Write using new proto-based Firestore representation #1869

merged 40 commits into from
Jun 28, 2024

Conversation

rfontanarosa
Copy link
Collaborator

@rfontanarosa rfontanarosa commented Jun 25, 2024 •
edited
Loading

Towards #1758

Screenshot 2024-06-10 alle 11 06 39

@rfontanarosa
create survey - implementation of proto
473e444
@rfontanarosa
fixed lib import
18290ee
@rfontanarosa
fix test dependency
940c5e8
@rfontanarosa
removed useless todo
b705df4
@rfontanarosa
fix test dependency
f866ebc
@rfontanarosa
Merge branch 'master' into rfontanarosa/new-proto-backed/create-survey
edd5558
@rfontanarosa
Merge branch 'master' into rfontanarosa/new-proto-backed/create-survey
fb6b303
@rfontanarosa
removed useless variable
96eb547
@rfontanarosa
updateSurveyTitle and updateSurveyTitle refactor, removed offlineBase…
b127403 
…MapSources
@rfontanarosa
Merge branch 'master' into rfontanarosa/new-proto-backed/create-survey
eab4489
@rfontanarosa
added ownerId, fixed possible undefined values
d2cc0d5
@rfontanarosa
Merge branch 'rfontanarosa/new-proto-backed/create-survey' of https:/…
fc83e99 
…/github.com/google/ground-platform into rfontanarosa/new-proto-backed/create-survey
@rfontanarosa
small changes, fixed typos, title -> name
ee2ec8a
@rfontanarosa
used new ProtoModelConverter
8c1aa75
@rfontanarosa
removed useless dependancy
e1c1f01
@rfontanarosa
used new ProtoModelConverter
1731498
@rfontanarosa
comments and name fixing
68c0f85
@rfontanarosa
Merge branch 'master' into rfontanarosa/new-proto-backed/create-survey
63d8cfe
@rfontanarosa
Merge branch 'master' into rfontanarosa/new-proto-backed/create-survey
a3831e5
@rfontanarosa
Merge branch 'master' into rfontanarosa/new-proto-backed/create-survey
dce3b50
@rfontanarosa
Merge branch 'master' into rfontanarosa/new-proto-backed/create-survey
94739c7
@rfontanarosa
removed console.log
7e83faa
@rfontanarosa
Merge branch 'master' into rfontanarosa/new-proto-backed/create-survey
c2434a2
@rfontanarosa
Merge branch 'master' into rfontanarosa/new-proto-backed/create-survey
b27b1de
@rfontanarosa
Merge branch 'master' into rfontanarosa/new-proto-backed/create-survey
fc8c809
@rfontanarosa
Merge branch 'master' into rfontanarosa/new-proto-backed/create-survey
6b832b2
@rfontanarosa
removed pretest script
b05ca56
@rfontanarosa
Merge branch 'master' into rfontanarosa/new-proto-backend/create-survey
685dcc4
gino-m
gino-m requested changes Jun 25, 2024
View reviewed changes
web/package.json Outdated Show resolved Hide resolved
@rfontanarosa rfontanarosa requested a review from gino-m June 26, 2024 08:26
@rfontanarosa rfontanarosa self-assigned this Jun 26, 2024
gino-m
gino-m requested changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! Some minor suggestions

web/src/app/converters/proto-model-converter.ts Outdated Show resolved Hide resolved
web/src/app/converters/proto-model-converter.ts Outdated Show resolved Hide resolved
@gino-m gino-m changed the title Write new surveys using proto-based Firestore representation [Create/edit survey] Write using new proto-based Firestore representation Jun 26, 2024
@rfontanarosa rfontanarosa requested a review from gino-m June 26, 2024 13:34
gino-m
gino-m previously approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@gino-m
Copy link
Collaborator

gino-m commented Jun 27, 2024

@rfontanarosa Run npm run lint:fix to fix lint errors.

@rfontanarosa rfontanarosa requested a review from gino-m June 27, 2024 17:09
gino-m
gino-m approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 !

@gino-m gino-m merged commit a9b2ce5 into master Jun 28, 2024
6 checks passed
@gino-m gino-m deleted the rfontanarosa/new-proto-backend/create-survey branch June 28, 2024 06:33
@gino-m gino-m mentioned this pull request Jun 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gino-m gino-m gino-m approved these changes

Assignees

@rfontanarosa rfontanarosa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rfontanarosa @gino-m